From 00ac29e53d66a7fbcac51f8a5416ed2a83a9e142 Mon Sep 17 00:00:00 2001 From: Norman Feske Date: Fri, 1 Mar 2019 19:27:40 +0100 Subject: [PATCH] Sculpt: avoid superfluous vertical space w/o info When a node of an index lacks an 'info' attribute, omit the corresponding fields in the pkg dialog to avoid blank vertical space. --- repos/gems/src/app/sculpt_manager/view/popup_dialog.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc b/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc index 67cb7730fd..df68cac547 100644 --- a/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc +++ b/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc @@ -20,10 +20,12 @@ using namespace Sculpt; void Popup_dialog::_gen_pkg_info(Xml_generator &xml, Component const &component) const { - gen_named_node(xml, "label", "info", [&] () { - xml.attribute("text", Component::Info(" ", component.info, " ")); }); + if (component.info.length() > 1) { + gen_named_node(xml, "label", "info", [&] () { + xml.attribute("text", Component::Info(" ", component.info, " ")); }); - _gen_info_label(xml, "pad1", ""); + _gen_info_label(xml, "pad1", ""); + } _gen_info_label(xml, "path", component.path); }