From 10d7427490c51ef66d7d08e549cc869d7cf0507c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josef=20S=C3=B6ntgen?= Date: Fri, 19 Apr 2024 13:11:38 +0200 Subject: [PATCH] sculpt: consider SoC board info for fb selection In contrast to platforms, like the PC, where the fb driver selection is a dynamic decision depending on the available hardware, on current ARM-based SoC machines this configuration is part of the static board information. Issue #5174. --- repos/gems/src/app/sculpt_manager/drivers.cc | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/repos/gems/src/app/sculpt_manager/drivers.cc b/repos/gems/src/app/sculpt_manager/drivers.cc index fde82b5e28..d8f857a154 100644 --- a/repos/gems/src/app/sculpt_manager/drivers.cc +++ b/repos/gems/src/app/sculpt_manager/drivers.cc @@ -68,12 +68,16 @@ class Sculpt::Drivers::Instance : Noncopyable, _resumed = { devices.attribute_value("resumed", 0u) }; /* - * The decision which fb driver to start depends on information - * about available devices from both the devices ROM and the - * platform info ROM, so we skip the update if the devices ROM - * is not ready yet. + * The decision which fb driver to start might depend (e.g. on PC) + * on information about available devices from both the devices ROM + * and the platform info ROM, so we skip the update if the devices + * ROM is not ready yet. + * + * On SoC platforms this information is provided by the static + * Board_info::Soc configuration and gets evluated instead to make + * the decision. */ - if (!devices.has_type("empty")) + if (!devices.has_type("empty") || _board_info.soc.fb) _fb_driver.update(_children, _board_info, _platform.xml()); _ps2_driver .update(_children, _board_info);