From 289cfa5fcfc44905ba7eb719a6517fd8832d40a3 Mon Sep 17 00:00:00 2001 From: Christian Helmuth Date: Mon, 8 Sep 2014 11:55:16 +0200 Subject: [PATCH] terminal: fix warning about uninitialized variable In fact the struct member `value` was not initialized for Invalid_entry. --- repos/gems/run/terminal_decoder.run | 1 + repos/gems/run/terminal_log.run | 1 + repos/os/include/terminal/decoder.h | 9 +++------ 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/repos/gems/run/terminal_decoder.run b/repos/gems/run/terminal_decoder.run index ff2bc16e6a..54bf32f6d2 100644 --- a/repos/gems/run/terminal_decoder.run +++ b/repos/gems/run/terminal_decoder.run @@ -8,6 +8,7 @@ install_config { + diff --git a/repos/gems/run/terminal_log.run b/repos/gems/run/terminal_log.run index 7a84f7919a..3089c69772 100644 --- a/repos/gems/run/terminal_log.run +++ b/repos/gems/run/terminal_log.run @@ -9,6 +9,7 @@ build { init drivers/framebuffer drivers/input + drivers/timer drivers/pci server/nitpicker server/nit_fb diff --git a/repos/os/include/terminal/decoder.h b/repos/os/include/terminal/decoder.h index 3744f949f8..4e83b77e2d 100644 --- a/repos/os/include/terminal/decoder.h +++ b/repos/os/include/terminal/decoder.h @@ -71,8 +71,8 @@ namespace Terminal { { enum { INVALID, NUMBER, CODE }; - int type; - int value; + int type = INVALID; + int value = 0; }; struct Number_entry : Entry @@ -85,10 +85,7 @@ namespace Terminal { Code_entry(int code) { type = CODE, value = code; } }; - struct Invalid_entry : Entry - { - Invalid_entry() { type = INVALID; } - }; + struct Invalid_entry : Entry { }; private: