From 324245d029b5afea1e06b0ab313f5f2ec7df1b61 Mon Sep 17 00:00:00 2001
From: Norman Feske <norman.feske@genode-labs.com>
Date: Tue, 29 Oct 2024 15:39:12 +0100
Subject: [PATCH] sculpt: restrict un-merging of fb connectors

In setups with 3 or more displays, allow the un-merging of connectors
only for the last mirrored connector. Otherwise, the operation would
implicitely change the order of connectors because the new discrete
connector needs appear after all merged connectors.

Issue #5286
---
 repos/gems/src/app/sculpt_manager/view/fb_widget.h | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/repos/gems/src/app/sculpt_manager/view/fb_widget.h b/repos/gems/src/app/sculpt_manager/view/fb_widget.h
index 5ecde73be2..cf957533e3 100644
--- a/repos/gems/src/app/sculpt_manager/view/fb_widget.h
+++ b/repos/gems/src/app/sculpt_manager/view/fb_widget.h
@@ -117,12 +117,21 @@ struct Sculpt::Fb_widget : Widget<Vbox>
 
 			s.sub_scope<Float>([&] (Scope<Vbox, Float> &s) {
 				s.sub_scope<Hbox>(id, [&] (Scope<Vbox, Float, Hbox> &s) {
-					s.sub_scope<Float>(Id { "equal" }, [&] (Scope<Vbox, Float, Hbox, Float> &s) {
+
+					/*
+					 * Restrict merge/unmerge toggle to last merged and first
+					 * discrete connector.
+					 */
+					bool const toggle_allowed = (count == num_merged || count == num_merged + 1);
+					Id const equal_id { toggle_allowed ? "equal" : "_equal" };
+
+					s.sub_scope<Float>(equal_id,
+						[&] (Scope<Vbox, Float, Hbox, Float> &s) {
 						s.sub_scope<Button>([&] (Scope<Vbox, Float, Hbox, Float, Button> &s) {
 							s.attribute("style", "vconn");
 							if (count <= num_merged)
 								s.attribute("selected", "yes");
-							if (count == num_merged || count == num_merged + 1) {
+							if (toggle_allowed) {
 								if (s.hovered() && !s.dragged())
 									s.attribute("hovered", "yes");
 							}