From 38f4b15df12501cb2f2845ca67dcd69dd27e69aa Mon Sep 17 00:00:00 2001 From: Alexander Boettcher Date: Thu, 20 Apr 2023 20:19:11 +0200 Subject: [PATCH] intel_fb: set default brightness of connector which is unconfigured to 70% Issue #4820 --- repos/pc/src/drivers/framebuffer/intel/pc/lx_user.c | 3 +-- repos/pc/src/drivers/framebuffer/intel/pc/main.cc | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/repos/pc/src/drivers/framebuffer/intel/pc/lx_user.c b/repos/pc/src/drivers/framebuffer/intel/pc/lx_user.c index bd6e90eb70..f102e9e567 100644 --- a/repos/pc/src/drivers/framebuffer/intel/pc/lx_user.c +++ b/repos/pc/src/drivers/framebuffer/intel/pc/lx_user.c @@ -221,8 +221,7 @@ static bool reconfigure(void * data) unsigned mode_id = 0; struct drm_connector *connector = NULL; - struct genode_mode conf_mode = { .enabled = 1, - .brightness = INVALID_BRIGHTNESS }; + struct genode_mode conf_mode = { }; if (!mode_set->connectors || !*mode_set->connectors) continue; diff --git a/repos/pc/src/drivers/framebuffer/intel/pc/main.cc b/repos/pc/src/drivers/framebuffer/intel/pc/main.cc index 91c33068e1..66800f75cd 100644 --- a/repos/pc/src/drivers/framebuffer/intel/pc/main.cc +++ b/repos/pc/src/drivers/framebuffer/intel/pc/main.cc @@ -197,6 +197,10 @@ void Framebuffer::Driver::generate_report(void *lx_data) void Framebuffer::Driver::lookup_config(char const * const name, struct genode_mode &mode) { + /* default settings, possibly overridden by explicit configuration below */ + mode.enabled = true; + mode.brightness = 70 /* percent */; + if (!config.valid()) return;