denshooter/genode
1
0
Fork 0
mirror of https://github.com/mmueller41/genode.git synced 2026-01-21 12:32:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rationale for not quoting single '"' chars

Browse Source
This commit is contained in:
Norman Feske
2012-01-08 22:05:26 +01:00
parent 8c3f832f09
commit 76127433b7
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ports/src/noux/main.cc
View File

@@ -339,15 +339,21 @@ static Noux::Args const &args_of_init_process()
static void quote(char *buf, Genode::size_t buf_len) static void quote(char *buf, Genode::size_t buf_len)
{ {
char c = '"';
/* /*
* Make sure to leave space at the end of buffer for the finishing '"' and * Make sure to leave space at the end of buffer for the finishing '"' and
* the null-termination. * the null-termination.
*/ */
char c = '"';
unsigned i = 0; unsigned i = 0;
for (; c && (i + 2 < buf_len); i++) for (; c && (i + 2 < buf_len); i++)
{ {
/*
* So shouldn't this have a special case for '"' characters inside the
* string? This is actually not needed because such a string could
* never be constructed via the XML config anyway. You can sneak in '"'
* characters only by quoting them in the XML file. Then, however, they
* are already quoted.
*/
char next_c = buf[i]; char next_c = buf[i];
buf[i] = c; buf[i] = c;
c = next_c; c = next_c;