From ad4211ae2cf07ad5b8a75320c11f6217a615e1d8 Mon Sep 17 00:00:00 2001 From: Piotr Tworek Date: Mon, 16 Nov 2020 01:28:09 +0100 Subject: [PATCH] os: Make Redistributor class inherit Genode::Interface. The Vmm::Gic::Gicd_banked::Redistributor is used with Constructible, but does not have a virtual destructor even though it has virtual methods. This prompts clang to issue the following warning: reconstructible.h:122:4: warning: destructor called on non-final 'Vmm::Gic::Gicd_banked::Redistributor' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor] Fix this by inheriting Genode::Interface. Issue #3984 --- repos/os/src/server/vmm/gic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/os/src/server/vmm/gic.h b/repos/os/src/server/vmm/gic.h index 1eec032795..44f06ba17c 100644 --- a/repos/os/src/server/vmm/gic.h +++ b/repos/os/src/server/vmm/gic.h @@ -134,7 +134,7 @@ class Vmm::Gic : public Vmm::Mmio_device Genode::Constructible _ppi[MAX_PPI]; Irq::List _pending_list; - struct Redistributor : Mmio_device + struct Redistributor : Mmio_device, Genode::Interface { unsigned cpu_id; bool last;