From cc193a9155f3d5e0c088c888ca87877c6d513bd4 Mon Sep 17 00:00:00 2001 From: Piotr Tworek Date: Wed, 4 Nov 2020 00:26:22 +0100 Subject: [PATCH] base: drop Trace::Session_component::_parent_levels Clang correctly asserts this private member variable is not used anywhere in the code. I'm not sure what the intention of the code is, might be this is a part of some unfinished feature. This patch just does the minimum amount of work to allow the code to build with clang. If required I can also drop the parent_levels constructor argument and clean up the call sites. Issue #3950 --- repos/base/src/core/include/trace/session_component.h | 1 - repos/base/src/core/trace_session_component.cc | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/repos/base/src/core/include/trace/session_component.h b/repos/base/src/core/include/trace/session_component.h index 3fdff80f58..c15cc696e8 100644 --- a/repos/base/src/core/include/trace/session_component.h +++ b/repos/base/src/core/include/trace/session_component.h @@ -41,7 +41,6 @@ class Genode::Trace::Session_component Sliced_heap _md_alloc { _ram, _local_rm }; Tslab _subjects_slab; Tslab _policies_slab; - unsigned const _parent_levels; Source_registry &_sources; Policy_registry &_policies; Subject_registry _subjects; diff --git a/repos/base/src/core/trace_session_component.cc b/repos/base/src/core/trace_session_component.cc index 183ce56333..fd86783754 100644 --- a/repos/base/src/core/trace_session_component.cc +++ b/repos/base/src/core/trace_session_component.cc @@ -173,7 +173,7 @@ Session_component::Session_component(Rpc_entrypoint &ep, Ram_allocator &ram, Region_map &local_rm, size_t arg_buffer_size, - unsigned parent_levels, + unsigned /* parent_levels */, Source_registry &sources, Policy_registry &policies) : @@ -182,7 +182,6 @@ Session_component::Session_component(Rpc_entrypoint &ep, _local_rm(local_rm), _subjects_slab(&_md_alloc), _policies_slab(&_md_alloc), - _parent_levels(parent_levels), _sources(sources), _policies(policies), _subjects(_subjects_slab, _sources),