mirror of
https://github.com/mmueller41/genode.git
synced 2026-01-21 20:42:56 +01:00
6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
75 lines
1.6 KiB
C++
75 lines
1.6 KiB
C++
/*
|
|
* \brief Common kernel initialization
|
|
* \author Martin Stein
|
|
* \author Stefan Kalkowski
|
|
* \date 2015-12-20
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2015-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <kernel/pd.h>
|
|
#include <kernel/cpu.h>
|
|
#include <kernel/kernel.h>
|
|
#include <kernel/lock.h>
|
|
#include <platform_pd.h>
|
|
#include <pic.h>
|
|
#include <board.h>
|
|
#include <platform_thread.h>
|
|
|
|
/* base includes */
|
|
#include <base/internal/unmanaged_singleton.h>
|
|
|
|
using namespace Kernel;
|
|
|
|
static_assert(sizeof(Genode::sizet_arithm_t) >= 2 * sizeof(size_t),
|
|
"Bad result type for size_t arithmetics.");
|
|
|
|
Pd &Kernel::core_pd() {
|
|
return unmanaged_singleton<Genode::Core_platform_pd>()->kernel_pd(); }
|
|
|
|
|
|
Pic &Kernel::pic() { return *unmanaged_singleton<Pic>(); }
|
|
|
|
extern "C" void kernel_init();
|
|
|
|
/**
|
|
* Setup kernel environment
|
|
*/
|
|
extern "C" void kernel_init()
|
|
{
|
|
static volatile bool pool_ready = false;
|
|
static volatile bool kernel_ready = false;
|
|
|
|
{
|
|
Lock::Guard guard(data_lock());
|
|
|
|
/* initialize current cpu */
|
|
pool_ready = cpu_pool().initialize(pic());
|
|
};
|
|
|
|
/* wait until all cpus have initialized their corresponding cpu object */
|
|
while (!pool_ready) { ; }
|
|
|
|
/* the boot-cpu initializes the rest of the kernel */
|
|
if (Cpu::executing_id() == Cpu::primary_id()) {
|
|
Lock::Guard guard(data_lock());
|
|
|
|
Genode::log("");
|
|
Genode::log("kernel initialized");
|
|
|
|
Core_thread::singleton();
|
|
kernel_ready = true;
|
|
} else {
|
|
/* secondary cpus spin until the kernel is initialized */
|
|
while (!kernel_ready) {;}
|
|
}
|
|
|
|
kernel();
|
|
}
|