From e3d4f7c96ee77d003027387e516ecd3a0187a9dd Mon Sep 17 00:00:00 2001
From: denshooter <dennis@konkol.net>
Date: Mon, 9 Mar 2026 01:02:10 +0100
Subject: [PATCH] Fix bugs and improve code quality
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fix memory leak: revoke object URLs in TimelineUploadSection
- Fix broken timeline photo URLs in admin panel (/data/... → /api/files/...)
- Remove duplicate bad-word list in AI moderation function
- Add input validation for type/status params in media and contributions API
- Add bulk-approve button in admin for pending contributions
- Add PATCH endpoint for bulk-approving all pending contributions

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 src/app/admin/page.tsx                   | 20 ++++++-
 src/app/api/candles/route.ts             |  1 +
 src/app/api/contributions/route.ts       | 66 +++++++++++++++++-------
 src/app/api/media/route.ts               | 11 ++++
 src/components/TimelineUploadSection.tsx | 11 +++-
 5 files changed, 85 insertions(+), 24 deletions(-)

diff --git a/src/app/admin/page.tsx b/src/app/admin/page.tsx
index 054f470..9512642 100644
--- a/src/app/admin/page.tsx
+++ b/src/app/admin/page.tsx
@@ -1138,7 +1138,7 @@ export default function AdminPage() {
                           {entry.media_filenames.split(',').slice(0, 3).map((filename, idx) => (
                             <img
                               key={idx}
-                              src={`/data/uploads/photos/${filename.trim()}`}
+                              src={`/api/files/${filename.trim()}`}
                               alt=""
                               className="w-10 h-10 object-cover rounded border border-warm-border"
                             />
@@ -1608,7 +1608,23 @@ export default function AdminPage() {
           </h2>
           
           {/* Status Filter Tabs */}
-          <div className="flex gap-2 mb-6">
+          <div className="flex flex-wrap gap-2 mb-6">
+            {timelineContributions.filter(c => c.status === 'pending').length > 0 && (
+              <button
+                onClick={async () => {
+                  if (!confirm(`Alle ${timelineContributions.filter(c => c.status === 'pending').length} ausstehenden Beiträge freigeben?`)) return
+                  await fetch('/api/contributions', {
+                    method: 'PATCH',
+                    headers: { 'Content-Type': 'application/json' },
+                    body: JSON.stringify({ action: 'approve-all-pending' }),
+                  })
+                  loadData()
+                }}
+                className="px-4 py-2 rounded-lg text-sm font-lora bg-green-600 hover:bg-green-700 text-white transition-colors"
+              >
+                ✓ Alle ausstehenden freigeben ({timelineContributions.filter(c => c.status === 'pending').length})
+              </button>
+            )}
             <button
               onClick={() => setContributionFilter('review')}
               className={`px-4 py-2 rounded-lg text-sm font-lora transition-colors ${
diff --git a/src/app/api/candles/route.ts b/src/app/api/candles/route.ts
index e35877a..4b8cf57 100644
--- a/src/app/api/candles/route.ts
+++ b/src/app/api/candles/route.ts
@@ -3,6 +3,7 @@ import { getDb } from '@/lib/db'
 
 export const runtime = 'nodejs'
 
+
 export async function GET() {
   const db = getDb()
   const candles = db
diff --git a/src/app/api/contributions/route.ts b/src/app/api/contributions/route.ts
index d065138..f91711e 100644
--- a/src/app/api/contributions/route.ts
+++ b/src/app/api/contributions/route.ts
@@ -1,8 +1,21 @@
 import { NextResponse } from 'next/server'
 import { getDb } from '@/lib/db'
+import { cookies } from 'next/headers'
+import { createHash } from 'crypto'
 
 export const runtime = 'nodejs'
 
+async function isAdmin() {
+  const cookieStore = await cookies()
+  const token = cookieStore.get('admin_auth')?.value
+  const expected = createHash('sha256')
+    .update(process.env.ADMIN_PASSWORD || 'change-me')
+    .digest('hex')
+  return token === expected
+}
+
+const VALID_CONTRIBUTION_TYPES = ['memory', 'timeline', 'media', 'recipe']
+
 // Simple bad word check
 function hasBadWords(text: string): { flag: boolean; reason?: string } {
   const lower = text.toLowerCase()
@@ -29,26 +42,10 @@ function hasBadWords(text: string): { flag: boolean; reason?: string } {
 // Background AI moderation with Ollama
 async function moderateWithAI(contributionId: number, content: string) {
   console.log(`[AI-Mod] Starting for ${contributionId}`)
-  
-  // Step 1: Instant bad word check
-  const lowerCheck = content.toLowerCase()
-  const badWords = ['hurensohn', 'arschloch', 'wichser', 'fotze']
-  const foundBadWord = badWords.find(word => lowerCheck.includes(word))
-  
-  if (foundBadWord) {
-    console.log(`[AI-Mod] ⚠️ INSTANT FLAG: "${foundBadWord}" detected!`)
-    const db = getDb()
-    db.prepare(`
-      UPDATE contributions 
-      SET status = 'flagged', moderation_reason = ?
-      WHERE id = ?
-    `).run(`Unangemessene Sprache: "${foundBadWord}"`, contributionId)
-    console.log(`[AI-Mod] ✅ FLAGGED ${contributionId} instantly`)
-    return
-  }
-  
-  // Step 2: AI check for subtle issues (irrelevant content, hidden insults etc.)
-  console.log(`[AI-Mod] No bad words, asking AI...`)
+
+  // AI check for subtle issues (irrelevant content, hidden insults etc.)
+  // Note: bad words are already checked before this function is called
+  console.log(`[AI-Mod] Asking AI...`)
   
   try {
     const prompt = `Du prüfst Beiträge für eine Gedenkseite einer verstorbenen Großmutter (Maria Malejka).
@@ -151,6 +148,13 @@ export async function POST(request: Request) {
       )
     }
 
+    if (!VALID_CONTRIBUTION_TYPES.includes(type)) {
+      return NextResponse.json(
+        { error: 'Invalid type' },
+        { status: 400 }
+      )
+    }
+
     // Require content for memory type, title for timeline
     if (type === 'memory' && !content) {
       return NextResponse.json(
@@ -216,6 +220,28 @@ export async function POST(request: Request) {
   }
 }
 
+export async function PATCH(request: Request) {
+  if (!await isAdmin()) {
+    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
+  }
+
+  try {
+    const { action } = await request.json()
+    if (action !== 'approve-all-pending') {
+      return NextResponse.json({ error: 'Unknown action' }, { status: 400 })
+    }
+
+    const db = getDb()
+    const result = db
+      .prepare(`UPDATE contributions SET status = 'approved' WHERE status = 'pending'`)
+      .run()
+    return NextResponse.json({ updated: result.changes })
+  } catch (error) {
+    console.error('[API] Bulk approve error:', error)
+    return NextResponse.json({ error: 'Failed' }, { status: 500 })
+  }
+}
+
 export async function GET(request: Request) {
   try {
     const { searchParams } = new URL(request.url)
diff --git a/src/app/api/media/route.ts b/src/app/api/media/route.ts
index fe07d2c..3b852b7 100644
--- a/src/app/api/media/route.ts
+++ b/src/app/api/media/route.ts
@@ -3,9 +3,20 @@ import { getDb } from '@/lib/db'
 
 export const runtime = 'nodejs'
 
+const VALID_TYPES = ['photo', 'video', 'music']
+const VALID_STATUSES = ['approved', 'pending', 'rejected', 'flagged']
+
 export async function GET(req: NextRequest) {
   const type = req.nextUrl.searchParams.get('type')
   const status = req.nextUrl.searchParams.get('status')
+
+  if (type && !VALID_TYPES.includes(type)) {
+    return NextResponse.json({ error: 'Invalid type' }, { status: 400 })
+  }
+  if (status && !VALID_STATUSES.includes(status)) {
+    return NextResponse.json({ error: 'Invalid status' }, { status: 400 })
+  }
+
   const db = getDb()
 
   let query = 'SELECT * FROM media WHERE 1=1'
diff --git a/src/components/TimelineUploadSection.tsx b/src/components/TimelineUploadSection.tsx
index e99c9fe..f2020e3 100644
--- a/src/components/TimelineUploadSection.tsx
+++ b/src/components/TimelineUploadSection.tsx
@@ -1,6 +1,6 @@
 'use client'
 
-import { useState } from 'react'
+import { useState, useEffect } from 'react'
 import { motion, AnimatePresence } from 'framer-motion'
 import { Calendar, MapPin, CheckCircle2, Loader2 } from 'lucide-react'
 
@@ -16,9 +16,16 @@ export default function TimelineUploadSection() {
     location: '',
   })
   const [files, setFiles] = useState<File[]>([])
+  const [objectUrls, setObjectUrls] = useState<string[]>([])
   const [isSubmitting, setIsSubmitting] = useState(false)
   const [submitSuccess, setSubmitSuccess] = useState(false)
 
+  useEffect(() => {
+    const urls = files.map(file => URL.createObjectURL(file))
+    setObjectUrls(urls)
+    return () => urls.forEach(url => URL.revokeObjectURL(url))
+  }, [files])
+
   const handleFileChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     if (e.target.files) {
       setFiles(Array.from(e.target.files))
@@ -219,7 +226,7 @@ export default function TimelineUploadSection() {
                   {files.map((file, i) => (
                     <div key={i} className="aspect-square rounded-lg overflow-hidden bg-warm-brown/5">
                       <img
-                        src={URL.createObjectURL(file)}
+                        src={objectUrls[i] ?? ''}
                         alt=""
                         className="w-full h-full object-cover"
                       />