portfolio/PRE_PUSH_CHECKLIST.md

Pre-Push Checklist - Dev Branch

Before pushing to the dev branch, verify all items below are complete.

✅ Required Checks

1. Code Quality

• No TypeScript errors: npm run build
• No ESLint errors: npm run lint
• All diagnostics resolved (only warnings allowed)
• Code formatted: npx prettier --write . (if using Prettier)

2. Database

• Prisma schema is valid: npx prisma format
• Migration script exists: prisma/migrations/create_activity_status.sql
• Migration tested locally: ./prisma/migrations/quick-fix.sh
• Database changes documented in CHANGELOG_DEV.md

3. Functionality Tests

• Dev server starts without errors: npm run dev
• Home page loads: http://localhost:3000
• Admin page accessible: http://localhost:3000/manage
• No hydration errors in console
• No "duplicate key" warnings in console
• Activity Feed loads without database errors
• API endpoints respond correctly:

  curl http://localhost:3000/api/n8n/status
  curl http://localhost:3000/api/health
  

4. Visual Checks

• Navbar doesn't overlap hero section
• All sections render correctly
• Project cards display properly
• About section tech stacks show correct colors
• Mobile responsive (test in DevTools)

5. Security

• No sensitive data in code (passwords, tokens, API keys)
• .env.local not committed (check .gitignore)
• Auth endpoints protected
• Rate limiting in place
• CSRF tokens implemented

6. Documentation

• CHANGELOG_DEV.md updated with all changes
• New features documented
• Breaking changes noted (if any)
• Migration guide included
• README files created for new features

7. Git Hygiene

• Commit messages are descriptive
• No merge conflicts
• Large files not committed (check git status)
• Build artifacts excluded (.next, node_modules)
• Commit history is clean (consider squashing if needed)

🧪 Testing Commands

Run these before pushing:

# 1. Build check
npm run build

# 2. Lint check
npm run lint

# 3. Type check
npx tsc --noEmit

# 4. Format check
npx prisma format

# 5. Start dev server
npm run dev

# 6. Test API endpoints
curl http://localhost:3000/api/n8n/status
curl http://localhost:3000/api/health
curl -I http://localhost:3000/manage

# 7. Check for hydration errors
# Open browser console and look for:
# - "Hydration failed" (should be NONE)
# - "two children with the same key" (should be NONE)

📋 Files Changed Review

Modified Files

• app/page.tsx - Spacer added for navbar
• app/components/About.tsx - Fixed duplicate keys
• app/components/Projects.tsx - Fixed duplicate keys
• app/components/ActivityFeed.tsx - Fixed hydration errors
• app/api/n8n/status/route.ts - Fixed TypeScript errors
• middleware.ts - Removed auth redirect
• prisma/schema.prisma - Added ActivityStatus model

New Files

• app/api/n8n/generate-image/route.ts
• app/components/admin/AIImageGenerator.tsx
• docs/ai-image-generation/ (all files)
• prisma/migrations/ (all files)
• CHANGELOG_DEV.md
• PRE_PUSH_CHECKLIST.md (this file)

🚨 Critical Checks

Must Have ZERO of These:

• No console.error() output when loading pages
• No React hydration errors
• No "duplicate key" warnings
• No database connection errors (after migration)
• No TypeScript compilation errors
• No ESLint errors (warnings are OK)

Environment Variables

Ensure these are documented but NOT committed:

# Required
DATABASE_URL=postgresql://...

# Optional (for new features)
N8N_WEBHOOK_URL=http://localhost:5678/webhook
N8N_SECRET_TOKEN=your-token
SD_API_URL=http://localhost:7860
AUTO_GENERATE_IMAGES=false
GENERATED_IMAGES_DIR=/path/to/public/generated-images

📝 Final Verification

Run this complete check:

# Clean build
rm -rf .next
npm run build

# Should complete without errors
# Then test the build
npm start

# Visit in browser
# - http://localhost:3000
# - http://localhost:3000/manage
# - http://localhost:3000/projects

🎯 Ready to Push?

If all items above are checked, run:

git status
git add .
git commit -m "feat: Fixed hydration errors, navbar overlap, and added AI image generation system"
git push origin dev

📞 Need Help?

If any checks fail:

1. Check CHANGELOG_DEV.md for troubleshooting
2. Review docs/ai-image-generation/SETUP.md
3. Check prisma/migrations/README.md for database issues
4. Review error messages carefully

---

Last Updated: 2024-01-15
Branch: dev
Status: Pre-merge checklist